fix: preserve deployment failure evidence - #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Post-merge Deploy run 30883763461 reached the staging upload with no
CLOUDFLARE_API_TOKEN. The upload correctly did not run, but the deployment wrapper queried prior state before installing its failure trap, so no failure evidence artifact was produced. The staging environment still needs a scoped token and runtime-secret provisioning; this PR fixes the repository-controlled evidence path only.Verification
pnpm typecheckpnpm test— 783 tests, including 9 deployment integration testspnpm buildpnpm exec changeset status --since origin/dev— no package bumpbash -non all changed deployment scriptsRelease metadata
No changeset is required: this changes private deployment scripts, tests, and documentation only. Generated release PR #25 remains correctly scoped to
@understudy/protocol@0.9.0and@understudy/connector@0.6.0.AI disclosure
Implemented and reviewed with Codex. The exact commands and independent review results are recorded above.